Fix the mila init and mila code commands on windows & WSL
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebrice
changed the title
mila init command on windowsmila init command on windows
lebrice
force-pushed
the
mila-init-windows
branch
from
61d608c to
ffd3f03
Compare
breuleux
reviewed
Nov 7, 2023
lebrice
force-pushed
the
mila-init-windows
branch
from
94267fe to
d947e15
Compare
lebrice
changed the title
mila init command on windowsmila init and mila code command on windows & WSL
lebrice
changed the title
mila init and mila code command on windows & WSLmila init and mila code commands on windows & WSL
breuleux
approved these changes
Nov 8, 2023
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Fixes mila-iqia#63 Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice <[email protected]>
Signed-off-by: Fabrice <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
lebrice
force-pushed
the
mila-init-windows
branch
from
022386d to
477997d
Compare
|
Hmm I just realized there's one last thing that might need fixing:
|
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
|
Ready for review again @breuleux |
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
lebrice
commented
Nov 9, 2023
tests/cli/test_init_command/test_setup_windows_ssh_config_from_wsl_reject_.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Fabrice Normandin <[email protected]>
satyaog
approved these changes
Nov 9, 2023
| @@ -206,6 +261,7 @@ def _add_ssh_entry( | |||
| ssh_config: SSHConfig, | |||
| host: str, | |||
| Host: str | None = None, | |||
| *, | |||
There was a problem hiding this comment.
What is the * is doing? Is it to grab all extra args? Should an exception be thrown instead?
There was a problem hiding this comment.
It's making it so _space_before and _space_after cannot be passed as positional arguments. This helps remove a typing error when calls to _add_ssh_entry are made with different **kwargs (Windows vs non-Windows)
There was a problem hiding this comment.
Could we, should we assert that nothing is in this *?
def ... , *_args, ...:
assert not _args
Only thinking out loud here
There was a problem hiding this comment.
Exactly! That's what using a * without a name does
Signed-off-by: Fabrice Normandin <[email protected]>
breuleux
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mila initare not supported on Windows #66hostname -scommand used to check if running on the Mila cluster isn't supported on Windows #69